Group shared ErrorTooltip with Tooltip#3546
Merged
mattseddon merged 1 commit intomainfrom Apr 2, 2023
Merged
Conversation
This was referenced Mar 24, 2023
mattseddon
force-pushed
the
fix-error-collection
branch
from
505803c to
fdba244
Compare
mattseddon
force-pushed
the
move-error-tooltip
branch
from
eddf411 to
3606992
Compare
mattseddon
force-pushed
the
fix-error-collection
branch
from
fdba244 to
7d1eedf
Compare
mattseddon
force-pushed
the
move-error-tooltip
branch
from
3606992 to
ffcec70
Compare
This was referenced Mar 24, 2023
sroy3
approved these changes
Mar 24, 2023
julieg18
approved these changes
Mar 24, 2023
mattseddon
force-pushed
the
fix-error-collection
branch
from
7d1eedf to
b9cea45
Compare
mattseddon
force-pushed
the
move-error-tooltip
branch
from
ffcec70 to
31a1adf
Compare
|
Code Climate has analyzed commit 31a1adf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.1% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7/9
main<- #3477 <- #3520 <- #3522 <- #3532 <- #3544 <- #3545 <- this <- #3547 <- #3548This PR moves the shared
ErrorTooltipfromwebview/src/shared/components/errorTooltip/ErrorTooltip.tsxtowebview/src/shared/components/tooltip/ErrorTooltip.tsx.Note: I looked into making the tooltip interactive/copyable but it seems the change is more involved as it would break the error tooltips shown in the experiment table:
Screen.Recording.2023-03-24.at.1.47.59.pm.mov